Omniscia Gnosis Guild Audit

Manual Review

Manual Review

A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in Gnosis Guild's Cowswap pre-signer module.

As the project at hand implements a Cowswap-integrating logic module, intricate care was put into ensuring that the execution flow within the system conforms to the specifications and restrictions laid forth within the protocol's specification.

We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed a potential cross-chain replay attack within the system, however, our analysis considers it to be inapplicable to the system at hand.

Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to the extent it need be, however, we advise it to be expanded in relation to the rationale behind the validTo and feeAmount sanitizations as they appear to be inconsequential.

A total of 6 findings were identified over the course of the manual review of which 2 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.

The finding table below enumerates all these security / behavioural findings:

IDSeverityAddressedTitle
COS-01MInexistent Exposure of Inverse Operation
GPS-01MInexistent Cross-Chain Replay Attack Protection