Omniscia Gnosis Guild Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in Gnosis Guild's Zodiac module revisions.
As the project at hand represents a delta between the original audit and the new changes introduced in its revision, intricate care was put into ensuring that the the system retains its conformity to the specifications and restrictions laid forth within the protocol's specification throughout the changes introduced.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed potential discrepancies in the way the system handles the AbiEncoded
parameter type as well as an allowance-related flaw within the system which could have had minor-to-moderate ramifications to its overall operation; we urge the Gnosis Guild team to promptly evaluate and remediate these exhibits if needed.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to an exemplary extent, containing thorough inline documentation throughout the codebase's functions, data structures, and interface declarations.
A total of 9 findings were identified over the course of the manual review of which 3 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
ID | Severity | Addressed | Title |
---|---|---|---|
PRE-01M | ![]() | ![]() | Discrepant Support of AbiEncoded Inline Evaluation |
PBR-01M | ![]() | ![]() | Removal of Important Security Check |
TYG-01M | ![]() | ![]() | Discrepant Support of AbiEncoded Inline Evaluation |