Omniscia Gnosis Guild Audit

AvatarIsOwnerOfERC721 Static Analysis Findings

AvatarIsOwnerOfERC721 Static Analysis Findings

AIO-01S: Multiple Top-Level Declarations

TypeSeverityLocation
Code StyleAvatarIsOwnerOfERC721.sol:L7, L13

Description:

The referenced file contains multiple top-level declarations that decrease the legibility of the codebase.

Example:

packages/evm/contracts/adapters/AvatarIsOwnerOfERC721.sol
7interface IModifier {
8 function avatar() external view returns (address);
9
10 function target() external view returns (address);
11}
12
13contract AvatarIsOwnerOfERC721 is ICustomCondition {

Recommendation:

We advise all highlighted top-level declarations to be split into their respective code files, avoiding unnecessary imports as well as increasing the legibility of the codebase.

Alleviation (e6d315f9170dcf4c622d504bd2fb6eafbdac9b75):

The Gnosis Guild team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase