Omniscia Kwenta Audit
EarlyVestFeeDistributor Code Style Findings
EarlyVestFeeDistributor Code Style Findings
EVF-01C: Inexplicable Value Literals
| Type | Severity | Location |
|---|---|---|
| Code Style |  | EarlyVestFeeDistributor.sol:L149 |
Description:
The referenced value literals are inexplicable as the RewardEscrowV2 contract exposes its DEFAULT_EARLY_VESTING_FEE and DEFAULT_DURATION members publicly.
Example:
contracts/EarlyVestFeeDistributor.sol
149rewardEscrowV2.createEscrowEntry(to, proportionalFees, 52 weeks, 90);Recommendation:
We advise the said value to be utilized, ensuring that the EarlyVestFeeDistributor remains compatible with RewardEscrowV2 upgrades.
Alleviation:
The DEFAULT_DURATION and DEFAULT_EARLY_VESTING_FEE getter functions are properly utilized in the referenced statement in place of value literals, optimizing the code's legibility and ensuring that it can dynamically adapt to upgrades of the RewardEscrowV2 contract.