MaverickV2IncentiveMatcherFactory Static Analysis Findings

MVM-01S: Inexistent Sanitization of Input Addresses

Type	Severity	Location
Input Sanitization		MaverickV2IncentiveMatcherFactory.sol:L39-L42

Description:

The linked function(s) accept address arguments yet do not properly sanitize them.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

Copy
39constructor(IMaverickV2VotingEscrowFactory _veFactory, IMaverickV2RewardFactory _rewardFactory) {
40    veFactory = _veFactory;
41    rewardFactory = _rewardFactory;
42}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that each address specified is non-zero.

Alleviation (07ad29f773f16bdfbae3d97d3a7c2f9d64866093):

The Maverick Protocol team specified that they wish to acknowledge these exhibits as the contracts involved will either be deployed by a factory performing those validations or by the Maverick Protocol team directly which is expected to perform them manually.

As such, we consider this exhibit to be acknowledged.