Omniscia Maverick Protocol Audit

MaverickV2VotingEscrowFactory Static Analysis Findings

MaverickV2VotingEscrowFactory Static Analysis Findings

MVY-01S: Inexistent Sanitization of Input Address

Description:

The linked function accepts an address argument yet does not properly sanitize it.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

v2-rewards/contracts/MaverickV2VotingEscrowFactory.sol
31constructor(IERC20 legacyVeMav_) {
32 legacyVeMav = legacyVeMav_;
33}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that the address specified is non-zero.

Alleviation (07ad29f773f16bdfbae3d97d3a7c2f9d64866093):

The Maverick Protocol team specified that they wish to acknowledge these exhibits as the contracts involved will either be deployed by a factory performing those validations or by the Maverick Protocol team directly which is expected to perform them manually.

As such, we consider this exhibit to be acknowledged.