Omniscia Mean Finance Audit

Manual Review

Manual Review

A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in Mean Finance's oracle system.

As the project at hand implements a Chainlink & Uniswap V3 integrating oracle system, intricate care was put into ensuring that the information flow within the system conforms to the specifications and restrictions laid forth within the protocol's specification and that the calculations and normalizations performed between the various modules are sound and safe.

We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed certain vulnerabilities within the system which could have had severe ramifications to its overall operation, however, they arise from extreme circumstances and thus have been classified as "minor" in severity.

Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to an exemplary extent.

A total of 14 findings were identified over the course of the manual review of which 11 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.

The finding table below enumerates all these security / behavioural findings:

IDSeverityAddressedTitle
OAR-01MCentralization of Oracle Aggregator Operation
OAR-02MIll-Advised Self-Ownership of Role
SCO-01MCentralization of Chainlink Price Evaluation
SCO-02MPotentially Incorrect Notion of Oracle Pairs
SCO-03MIll-Advised Self-Ownership of Role
TOE-01MIll-Advised Self-Ownership of Role
TOE-02MPotential Race Condition of Price Quote
TOE-03MPotentially Restrictive Underlying Disassociation
UVA-01MImproper Integration of Gas Paradigm
UVA-02MIll-Advised Self-Ownership of Role
UVA-03MPotentially Manipulate-able Liquidity Measurement