UniswapV3Adapter Static Analysis Findings

UVA-01S: Inexistent Sanitization of Input Address

Type	Severity	Location
Input Sanitization		UniswapV3Adapter.sol:L36

Description:

The linked function accepts an address argument yet does not properly sanitize it.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

Copy
34constructor(InitialConfig memory _initialConfig) {
35  if (_initialConfig.superAdmin == address(0)) revert ZeroAddress();
36  UNISWAP_V3_ORACLE = _initialConfig.uniswapV3Oracle;

Recommendation:

We advise some basic sanitization to be put in place by ensuring that the address specified is non-zero.

Alleviation:

The Mean Finance team stated that the referenced address has a function immediately invoked which would in turn fail should the original data entry be zero. As a result, we consider this exhibit nullified.