Omniscia Mean Finance Audit
ArbitraryExecutionPermit2Adapter Code Style Findings
ArbitraryExecutionPermit2Adapter Code Style Findings
AEP-01C: Ill-Advised Library Syntax
Type | Severity | Location |
---|---|---|
Code Style | ArbitraryExecutionPermit2Adapter.sol:L22 |
Description:
The wildcard syntax for a using A for B
statement is highly discouraged as it may lead to misuse of the Token
library.
Example:
src/base/ArbitraryExecutionPermit2Adapter.sol
22using Token for *;
Recommendation:
We advise the Token
library to be applied to the address
as well as IERC20
data types as expected by it.
Alleviation:
The referenced library usage syntax has been standardized to its explicit format, ensuring that the Token
library is properly attached to the address
as well as IERC20
data types it is expected to.