Omniscia Mean Finance Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in Mean Finance's universal Permit2
adapter.
As the project at hand implements a Permit2
integrating adapter, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed multiple vulnerabilities around permits within the system which could have had severe ramifications to its overall operation; we urge the Mean Finance team to promptly remediate all major findings within the report.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to the extent it need be.
A total of 11 findings were identified over the course of the manual review of which 9 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
ID | Severity | Addressed | Title |
---|---|---|---|
AEP-01M | Potential Increase of Functionality | ||
AEP-02M | Lingering Token Approvals | ||
AEP-03M | Race-Condition of Permit2 Approvals | ||
PTS-01M | Inexistent Validation of Native Amount | ||
PTS-02M | Inexistent Compatibility of Native Funds | ||
SPA-01M | Incorrect Assumption of Input | ||
SPA-02M | Potential Re-Entrancy Compromise | ||
SPA-03M | Race-Condition of Permit2 Approvals | ||
TNE-01M | Potentially Invalidated Assumption |