Omniscia Mean Finance Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in Mean Finance's swapper module.
As the project at hand implements an EIP-20 DEX integrating single point of contact, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We identified potential loss-of-funds within the system if its functions are mis-used which can be alleviated via code constraints.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to a great extent, however, we would like to note that this audit does not constitute an audit of all the "swapper" implementations that the swap proxy will interact with.
A total of 15 findings were identified over the course of the manual review of which 5 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
ID | Severity | Addressed | Title |
---|---|---|---|
RSP-01M | Potential Mismatch of Contract Functionality | ||
SRY-01M | Ambiguous Role Management | ||
SRY-02M | Ill-Advised Self-Ownership of Role | ||
TAR-01M | Inexistent Validation of Ether Value | ||
TRS-01M | Inexistent Validation of Ether Value |