Governable Static Analysis Findings

GEL-01S: Inexistent Sanitization of Input Address

Type	Severity	Location
Input Sanitization		Governable.sol:L36-L39

Description:

The linked function accepts an address argument yet does not properly sanitize it.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

Copy
36function setPendingGovernor(address _pendingGovernor) external onlyGovernor {
37  pendingGovernor = _pendingGovernor;
38  emit PendingGovernorSet(_pendingGovernor);
39}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that the address specified is non-zero.

Alleviation:

The Mean Finance team stated that they wish to retain the ability to set the pendingGovernor as the zero-address to cancel a pending transfer of governor-ship and as such we consider this exhibit nullified.