Omniscia Mean Finance Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in Mean Finance's transformer module.
As the project at hand implements an asset transformer system, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification and that the transformers currently available are properly integrating with their respective standards.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed a mis-implementation within the system which could have had moderate ramifications to its overall operational capacity, however, it was conveyed ahead of time to the Mean Finance team to be promptly remediated.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to an exemplary extent.
A total of 12 findings were identified over the course of the manual review of which 9 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
ID | Severity | Addressed | Title |
---|---|---|---|
CDT-01M | Inexistent Validation of Asset Transfer | ||
ERC-01M | Inexistent Validation of Array Length | ||
ERC-02M | Improper Approval Methodology | ||
ERC-03M | Improper payable Trait Definitions | ||
ERC-04M | Inexistent Enforcement of Slippage Checks | ||
PTW-01M | Inexistent Validation of Array Length | ||
PTW-02M | Improper payable Trait Definitions | ||
TRY-01M | Inexistent Deprecation Workflow | ||
TRY-02M | Incorrect Balance Measurement Methodology |