Governable Static Analysis Findings

GOV-01S: Inexistent Sanitization of Input Address

Type	Severity	Location
Input Sanitization		Governable.sol:L36-L39

Description:

The linked function accepts an address argument yet does not properly sanitize it.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

Copy
36function setPendingGovernor(address _pendingGovernor) external onlyGovernor {
37  pendingGovernor = _pendingGovernor;
38  emit PendingGovernorSet(_pendingGovernor);
39}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that the address specified is non-zero.

Alleviation (6ed56b5449ca241fc6be369d44f392f1f5313f93):

The Mean Finance team evaluated this exhibit but opted not to apply a remediation for it in the current version of the codebase as they deem it a non-issue. As a result, we consider the exhibit acknowledged.