Omniscia MetaSoccer Audit
EntropyManager Code Style Findings
EntropyManager Code Style Findings
EMR-01C: Illegible Struct Initialization
Type | Severity | Location |
---|---|---|
Code Style | EntropyManager.sol:L72 |
Description:
The Request
struct initialization in the linked statement is slightly illegible as it uses index-based assignments.
Example:
contracts/EntropyManager.sol
72Request memory request = Request(false, true, _address, _tokenId, _index, 0);
Recommendation:
We advise the new key-value format to be utilized here instead increasing the legibility of the statement significantly.
Alleviation:
The key-value format is now utilized in the codebase as advised.