Omniscia Myso Finance Audit

Manual Review

Manual Review

A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in Myso Finance's option system.

As the project at hand implements an option system with a Dutch style auction and off-chain based approach, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification.

We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We did not identify any noteworthy vulnerabilities within the system and instead noted minor severity recommendations that can enhance the system's functionality.

Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to an exemplary extent, containing extensive in-line documentation as well as an instructive README file that adequately describes the system's implementation.

A total of 8 findings were identified over the course of the manual review of which 4 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.

The finding table below enumerates all these security / behavioural findings:

IDSeverityAddressedTitle
FHR-01MImproper Error Condition Evaluation
IER-01MInexistent Exposure of Initializer
RRE-01MInexistent Support of Underlying Token Fee Fulfillment
RRE-02MPotentially Unsupported Legacy EIP-1271 Wallets