Omniscia Myso Finance Audit
Router Static Analysis Findings
Router Static Analysis Findings
RRE-01S: Inexistent Sanitization of Input Address
| Type | Severity | Location |
|---|---|---|
| Input Sanitization |  | Router.sol:L38-L40 |
Description:
The linked function accepts an address argument yet does not properly sanitize it.
Impact:
The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.
Example:
contracts/Router.sol
38constructor(address initOwner, address _escrowImpl) Ownable(initOwner) {39 escrowImpl = _escrowImpl;40}Recommendation:
We advise some basic sanitization to be put in place by ensuring that the address specified is non-zero.
Alleviation (d9eb549dcca601db1fa91336ebe4d08fa8f2908b):
The input _escrowImpl address argument of the Router::constructor function is adequately sanitized as non-zero in the latest in-scope revision of the codebase, addressing this exhibit.