Omniscia Native Audit
Code Style
Code Style
During the manual portion of the audit, we identified 40 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.
Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.
These optimizations are enumerated below:
| ID | Severity | Addressed | Title |
|---|---|---|---|
| BLB-01C |  |  | Outdated Implementation |
| CVN-01C | |  | Inefficient Named Return Variable |
| CVN-02C | | | Inexistent Error Message |
| CSP-01C | | | Repetitive Value Literal |
| FMH-01C | | | Inexistent Error Messages |
| MLL-01C | | | Loop Iterator Optimization |
| MLL-02C | |  | Re-Order of Input Arguments |
| NDC-01C | | | Inexistent Error Message |
| ORE-01C | | | Improper Specialized Encoding Mechanism |
| ORE-02C | | | Inexistent Error Messages |
| ORE-03C | | | Potential Enhancement of Functionality |
| PPS-01C | | | Repetitive Value Literals |
| PVN-01C | | | Redundant Method Implementation |
| PLO-01C | | | Deprecated Conditional Revert Pattern |
| PLO-02C | | | Ineffectual Conditional Check |
| PLO-03C | | | Inefficient Hash of Literal |
| PLO-04C | | | Inefficient Loop Limit Evaluation |
| PLO-05C | | | Inefficient Memory Pointer |
| PLO-06C | | | Inexistent Error Message |
| PLO-07C | | | Inexplicable Logic Split |
| PLO-08C | | | Loop Iterator Optimizations |
| PLO-09C | | | Loose Definition of EIP712 Arguments |
| PLO-10C | | | Redundant Input Arguments |
| PLO-11C | | | Repetitive Value Literal |
| PLO-12C | | | Suboptimal Struct Declaration Styles |
| PLO-13C | | | Variable Mutability Specifiers (Immutable) |
| PDR-01C | | | Redundant Parenthesis Statement |
| PFY-01C | | | Deprecated Conditional Revert Pattern |
| PFY-02C | | | Generic Typographic Mistakes |
| PFY-03C | | | Inexistent Error Message |
| PFY-04C | | | Redundant Parenthesis Statements |
| RYR-01C | | | Loop Iterator Optimization |
| RYR-02C | | | Non-Standard Definition of Function Signatures |
| RYR-03C | | | Redundant Return Statement |
| RYR-04C | | | Redundantly Convoluted Calls |
| RRE-01C | | | Generic Typographic Mistake |
| RRE-02C | |  | Inexistent Support of Contract Payer |
| RRE-03C | | | Redundant Parenthesis Statements |
| SCT-01C | | | Optimization of Check Legibility |
| UVP-01C | | | Redundant Parenthesis Statements |