Omniscia Native Audit

PeripheryPayments Code Style Findings

PeripheryPayments Code Style Findings

PPS-01C: Repetitive Value Literals

TypeSeverityLocation
Code StylePeripheryPayments.sol:L52, L59, L73, L79

Description:

The linked value literals are repeated across the codebase multiple times.

Example:

contracts/libraries/PeripheryPayments.sol
52require(feeBips > 0 && feeBips <= 100, "Fee out of range");

Recommendation:

We advise each to be set to its dedicated constant variable instead optimizing the legibility of the codebase.

Alleviation:

The Native team evaluated this exhibit but opted not to apply a remediation for it as they consider it inconsequential.