ConstantSumPricer Static Analysis Findings

CSP-01S: Illegible Numeric Value Representation

Type	Severity	Location
Code Style		ConstantSumPricer.sol:L14, L15, L26

Description:

The linked representation of a numeric literal is sub-optimally represented decreasing the legibility of the codebase.

Example:

Copy
14uint256 amountInWithFee = amountIn * (10000 - fee);

Recommendation:

To properly illustrate the value's purpose, we advise the following guidelines to be followed. For values meant to depict fractions with a base of 1e18, we advise fractions to be utilized directly (i.e. 1e17 becomes 0.1e18) as they are supported. For values meant to represent a percentage base, we advise each value to utilize the underscore (_) separator to discern the percentage decimal (i.e. 10000 becomes 100_00, 300 becomes 3_00 and so on). Finally, for large numeric values we simply advise the underscore character to be utilized again to represent them (i.e. 1000000 becomes 1_000_000).

Alleviation:

The underscore separator has been properly introduced to the 10000 literal, optimizing its legibility in the code.