Omniscia SaucerSwap Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in SaucerSwap's periphery system.
As the project at hand implements a Uniswap-V3 like periphery system, intricate care was put into ensuring that the flow of funds & assets within the system conforms to the specifications and restrictions laid forth within the protocol's specification.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed multiple mis-integrations of the Hedera Protocol within the system's TransferHelper
which would significantly affect the router's capabilities in transferring tokens outwards and inwards when executing swaps.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to the extent it need be.
A total of 10 findings were identified over the course of the manual review of which 6 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
ID | Severity | Addressed | Title |
---|---|---|---|
BLB-01M | Inexistent Bound Checks | ||
NFT-01M | Improper Argument Data Types | ||
PPS-01M | Incorrect Transfer of Funds | ||
PIR-01M | Incorrect Pool Creation Fee Acquisition | ||
THR-01M | Inexistent Cast of Variable | ||
THR-02M | Inexistent Integration of the Hedera Token Service |