NonfungiblePositionManager Static Analysis Findings

NPM-01S: Illegible Numeric Value Representation

Type	Severity	Location
Code Style		NonfungiblePositionManager.sol:L95

Description:

The linked representation of a numeric literal is sub-optimally represented decreasing the legibility of the codebase.

Example:

Copy
95expiry.autoRenewPeriod = 8000000;

Recommendation:

To properly illustrate the value's purpose, we advise the following guidelines to be followed. For values meant to depict fractions with a base of 1e18, we advise fractions to be utilized directly (i.e. 1e17 becomes 0.1e18) as they are supported. For values meant to represent a percentage base, we advise each value to utilize the underscore (_) separator to discern the percentage decimal (i.e. 10000 becomes 100_00, 300 becomes 3_00 and so on). Finally, for large numeric values we simply advise the underscore character to be utilized again to represent them (i.e. 1000000 becomes 1_000_000).

Alleviation (d8d187efd1fa23b943c82694aaaccb5b9e427096):

The overall contract has been refactored to instantiate the NFT using a separate function that accepts the automatic renewal period as an argument, rendering this exhibit indirectly alleviated as the literal is no longer present in the codebase.