Omniscia Steer Protocol Audit

Code Style

Code Style

During the manual portion of the audit, we identified 20 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.

Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.

These optimizations are enumerated below:

IDSeverityAddressedTitle
ABL-01CGeneric Typographic Mistakes
ABL-02CIneffectual Usage of Safe Arithmetics
ABL-03CInefficient Data Type
ABL-04CInexistent Error Messages
ABL-05CInexplicable Value Literals
AMP-01CGeneric Typographic Mistake
AMP-02CInefficient Usage of Storage Space
AMP-03CLoop Iterator Optimizations
AMP-04CRedundant Convoluted Logic Structure
AMP-05CRepetitive Value Literals
ASP-01CRepetitive Value Literals
QSB-01CGeneric Typographic Mistakes
QSB-02CInefficient Data Type
QSB-03CInexistent Error Messages
QSB-04CInexplicable Value Literals
QSM-01CGeneric Typographic Mistake
QSM-02CInefficient Usage of Storage Space
QSM-03CRedundant Convoluted Logic Structure
QSM-04CRepetitive Value Literals
QSS-01CRepetitive Value Literals