Omniscia Steer Protocol Audit
AlgebraSinglePositionLiquidityManager Code Style Findings
AlgebraSinglePositionLiquidityManager Code Style Findings
ASP-01C: Repetitive Value Literals
| Type | Severity | Location |
|---|---|---|
| Code Style |  | AlgebraSinglePositionLiquidityManager.sol:L99, L101, L228, L232 |
Description:
The linked value literals are repeated across the codebase multiple times.
Example:
contracts/vault-types/AlgebraLiquidityManagers/AlgebraSinglePositionLiquidityManager.sol
99FullMath.mulDiv(balance0, totalWeight, 1e4),Recommendation:
We advise each to be set to its dedicated constant variable instead optimizing the legibility of the codebase.
Alleviation (0c3f85c7c1):
The Steer Protocol team has stated that they do not wish to introduce constant declarations to the contract in fear of increasing its bytecode size.
All variables declared as constant are compilation artefacts and do not affect the contract's bytecode size. As such, we consider this exhibit addressed but advise the Steer Protocol team to reconsider applying it.
Alleviation (b1b5eabd4d):
All repetitive value literals have been properly defined as constant variables in the AlgebraBaseLiquidityManager dependency of the contract, alleviating this exhibit in full.