Omniscia Steer Protocol Audit
Code Style
Code Style
During the manual portion of the audit, we identified 24 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.
Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.
These optimizations are enumerated below:
| ID | Severity | Addressed | Title |
|---|---|---|---|
| FP3-01C |  |  | Optimization of Conditional Evaluations |
| FP3-02C | |  | Recalculation of Square Root Ratios at Ticks |
| FP3-03C | | | Repetitive Value Literal |
| GPN-01C | | | Generic Typographic Mistake |
| GPN-02C | | | Inefficient Recalculations of Square Root Ratios |
| GPN-03C | | | Redundant Parenthesis Statements |
| GPN-04C | | | Redundant Type Casting |
| GPN-05C | | | Unutilized Constant |
| GPN-06C | | | Variable Mutability Specifiers (Immutable) |
| PHR-01C | | | Generic Typographic Mistakes |
| PHR-02C | | | Ineffectual Usage of Safe Arithmetics |
| PHR-03C | |  | Redundant Evaluation of Conditional |
| PHR-04C | | | Repetitive Value Literal |
| PV1-01C | | | Duplicate Validation of Initialization |
| PV1-02C | | | Generic Typographic Mistake |
| PV1-03C | | | Inefficient Signature Encodings |
| PV1-04C | | | Inexistent Error Messages |
| PV1-05C | | | Misleading Function Name |
| PV1-06C | | | Redundant Distinction of Conditionals |
| PV1-07C | | | Repeated Constant Declarations |
| PV1-08C | | | Unresolved TODO Comment |
| PV1-09C | | | Unused Contract Constants |
| WTS-01C | | | Generic Typographic Mistake |
| WTS-02C | | | Variable Mutability Specifier (Immutable) |