Omniscia Steer Protocol Audit

Whitelist Static Analysis Findings

Whitelist Static Analysis Findings

WTS-01S: Inexistent Event Emissions

TypeSeverityLocation
Language SpecificWhitelist.sol:
I-1: L21-L25
I-2: L27-L31

Description:

The linked functions adjust sensitive contract variables yet do not emit an event for it.

Example:

src/Whitelist.sol
21function addToWhitelist(address[] memory _addresses) external onlyOwner {
22 for (uint256 i = 0; i < _addresses.length; i++) {
23 whitelist[_addresses[i]] = true;
24 }
25}

Recommendation:

We advise an event to be declared and correspondingly emitted for each function to ensure off-chain processes can properly react to this system adjustment.

Alleviation:

The WhitelistAdded, and WhitelistRemoved events were introduced to the codebase and are correspondingly emitted in the Whitelist::addToWhitelist, and Whitelist::removeFromWhitelist functions respectively, addressing this exhibit in full.