SushiManagementFeeAlm Code Style Findings

SMF-01C: Ineffectual Usage of Safe Arithmetics

Type	Severity	Location
Language Specific		SushiManagementFeeAlm.sol:L185, L194

Description:

The linked mathematical operation is guaranteed to be performed safely by logical inference, such as surrounding conditionals evaluated in require checks or if-else constructs.

Example:

Copy
185if (currentTimestamp <= lastAccrual) {
186    return 0;
187}
188
189uint256 supply = totalSupply();
190if (supply == 0) {
191    return 0;
192}
193
194uint256 elapsed = currentTimestamp.sub(lastAccrual);

Recommendation:

We advise the linked statement to avoid usage of the SafeMath library as it is currently redundant.

Alleviation:

The Steer Protocol team evaluated this exhibit and opted to retain the current safe approach out of an abundance of caution.

SMF-02C: Inexistent Error Messages

Type	Severity	Location
Code Style		SushiManagementFeeAlm.sol: • I-1: L61-L64 • I-2: L65-L68 • I-3: L69 • I-4: L78

Description:

The linked require checks have no error messages explicitly defined.

Example:

Copy
61require(
62    _maxTickChange > MAX_TICK_CHANGE_MIN &&
63        _maxTickChange < MAX_TICK_CHANGE_MAX
64);

Recommendation:

We advise each to be set so to increase the legibility of the codebase and aid in validating the require checks' conditions.

Alleviation:

The Steer Protocol team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.