SushiManagementFeeAlm Static Analysis Findings

SMF-01S: Inexistent Event Emissions

Type	Severity	Location
Language Specific		SushiManagementFeeAlm.sol: • I-1: L136-L142 • I-2: L144-L150 • I-3: L152-L158

Description:

The linked functions adjust sensitive contract variables yet do not emit an event for it.

Example:

Copy
136function setManagementFeeBps(
137    uint256 newFeeBps
138) external onlyRole(STEER_ROLE) {
139    require(newFeeBps <= DIVISOR, "FEE");
140    _accrueManagementFee();
141    managementFeeBps = newFeeBps;
142}

Recommendation:

We advise an event to be declared and correspondingly emitted for each function to ensure off-chain processes can properly react to this system adjustment.

Alleviation:

The ManagementFeeUpdated, FeeRecipientUpdated, and SingleDepositorUpdated events were introduced to the codebase and are correspondingly emitted in the SushiManagementFeeALM::setManagementFeeBps, SushiManagementFeeALM::setManagementFeeRecipient, and SushiManagementFeeALM::setSingleDepositor functions respectively, addressing this exhibit in full.