Omniscia Steer Protocol Audit
Code Style
Code Style
During the manual portion of the audit, we identified 13 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.
Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.
These optimizations are enumerated below:
| ID | Severity | Addressed | Title |
|---|---|---|---|
| LMH-01C |  |  | Ineffectual Usage of Safe Arithmetics |
| LMH-02C | | | Redundant Salt Argument |
| LMV-01C | | | Ineffectual Usage of Safe Arithmetics |
| LMV-02C | | | Inexistent Error Messages |
| LMV-03C | | | Misleading Minimum Share Notion |
| LMV-04C | | | Redundant Assignments |
| LMV-05C | | | Redundant Execution of Full Withdrawal in Initial State |
| LMV-06C | | | Redundant Parenthesis Statements |
| LMV-07C | | | Redundant Repetition of Data Point |
| LMV-08C | | | Redundant Usage of Nested Iterator |
| LMV-09C | | | Repeated Constant Declarations |
| LMV-10C | | | Unnecessary TODO Comment |
| LMV-11C | | | Unresolved TODO Comment |