Omniscia Tangible Audit
Code Style
Code Style
During the manual portion of the audit, we identified 24 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.
Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.
These optimizations are enumerated below:
ID | Severity | Addressed | Title |
---|---|---|---|
AUS-01C | Gas Inefficient Sorting Algorithm | ||
AUS-02C | Redundant Usage of Checked Arithmetics | ||
BTE-01C | Inefficient mapping Lookups | ||
BTE-02C | Inexistent Error Messages | ||
BTE-03C | Multiple Expensive Balance Measurements | ||
BTE-04C | Potentially Inefficient Array Shifts | ||
BTE-05C | Redundant Assignment & Addition Operations | ||
BTE-06C | Redundant Evaluation of Claimable Rent | ||
BTE-07C | Redundant Invocations of Decimals | ||
BTE-08C | Redundant Parenthesis Statements | ||
BTE-09C | Redundant Yield of Boolean | ||
BTE-10C | Repetitive Value Literals | ||
BTE-11C | Suboptimal Struct Declaration Styles | ||
BMR-01C | Generic Typographic Mistake | ||
BMR-02C | Inefficient Loop Limit Evaluation | ||
BMR-03C | Inefficient On-Chain Sorting of Features | ||
BMR-04C | Multiple Mappings w/ Shared Key | ||
BMR-05C | Repetitive Invocations of Getter Functions | ||
BMR-06C | Sub-Optimal Availability Mappings | ||
BVC-01C | Redundant Extra Data Payload | ||
GVR-01C | Inefficient Data Structure | ||
GVR-02C | Redundant Casting Operation | ||
GVR-03C | Suboptimal Segregation of Data | ||
VRF-01C | Potential Optimization of Variable Mutability |