Omniscia Teahouse Finance Audit
Code Style
Code Style
During the manual portion of the audit, we identified 34 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.
Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.
These optimizations are enumerated below:
ID | Severity | Addressed | Title |
---|---|---|---|
AAT-01C | Loop Iterator Optimizations | ||
AOE-01C | Inefficient mapping Lookups | ||
AOE-02C | Loop Iterator Optimizations | ||
AOE-03C | Redundant Initialization of Pool Information | ||
AOE-04C | Redundant Parenthesis Statements | ||
AOE-05C | Repetitive Value Literal | ||
TVP-01C | Inefficient Square Root Implementation | ||
TVP-02C | Loop Iterator Optimizations | ||
TVP-03C | Redundant Parenthesis Statements | ||
TVP-04C | Redundant Type Cast Operations | ||
TVV-01C | Deprecated Usage of Signature Value Literals | ||
TVV-02C | Inefficient Emission of Captured Fees | ||
TVV-03C | Inefficient Emissions of Contextual Variable | ||
TVV-04C | Inefficient On-Chain Path Calculation | ||
TVV-05C | Inefficient Ownership Transfer | ||
TVV-06C | Inefficient Removal of Array Element | ||
TVV-07C | Inefficient Shift Operation | ||
TVV-08C | Inefficient Variable Mutability (Constant) | ||
TVV-09C | Inefficient Variable Mutability (Immutable) | ||
TVV-10C | Loop Iterator Optimizations | ||
TVV-11C | Redundant Local Variables | ||
TVV-12C | Redundant Maintenance of Total Amounts | ||
TVV-13C | Repetitive Value Literal | ||
TVH-01C | Deprecated Revert Statements | ||
TVH-02C | Generic Typographic Mistake | ||
TVH-03C | Loop Iterator Optimizations | ||
TVH-04C | Potentially Redundant Rescue Functions | ||
TVH-05C | Unreachable Code | ||
UVP-01C | Generic Typographic Mistake | ||
UVP-02C | Ineffectual Usage of Safe Arithmetics | ||
UVP-03C | Inefficient Emissions of Contextual Variable | ||
UVP-04C | Loop Iterator Optimization | ||
UVP-05C | Potential Usability Enhancement | ||
UVP-06C | Redundant Recalculation of Value |