TesseractVaultDeployer Static Analysis Findings

TVD-01S: Illegible Numeric Value Representations

Type	Severity	Location
Code Style		TesseractVaultDeployer.sol: • I-1: L54 • I-2: L55

Description:

The linked representations of numeric literals are sub-optimally represented decreasing the legibility of the codebase.

Example:

Copy
54uint256 public constant MAX_MANAGEMENT_FEE = 1000; // 10%

Recommendation:

To properly illustrate each value's purpose, we advise the following guidelines to be followed. For values meant to depict fractions with a base of 1e18, we advise fractions to be utilized directly (i.e. 1e17 becomes 0.1e18) as they are supported. For values meant to represent a percentage base, we advise each value to utilize the underscore (_) separator to discern the percentage decimal (i.e. 10000 becomes 100_00, 300 becomes 3_00 and so on). Finally, for large numeric values we simply advise the underscore character to be utilized again to represent them (i.e. 1000000 becomes 1_000_000).

Alleviation (fdf0694b5c38834fa5a20cb2765766924d34f5d4):

The referenced value literals have been updated in their representation to 10_00, and 50_00 respectively in accordance with the recommendation's underscore style, addressing this exhibit.