Omniscia Tren Finance Audit
CommunityIssuance Static Analysis Findings
CommunityIssuance Static Analysis Findings
CIE-01S: Inexistent Event Emission
Type | Severity | Location |
---|---|---|
Language Specific | CommunityIssuance.sol:L74-L79 |
Description:
The linked function adjusts a sensitive contract variable yet does not emit an event for it.
Example:
contracts/TREN/CommunityIssuance.sol
74function setAdminContract(address _adminContract) external onlyOwner {75 if (_adminContract == address(0)) {76 revert CommunityIssuance__InvalidAdminContract();77 }78 adminContract = _adminContract;79}
Recommendation:
We advise an event
to be declared and correspondingly emitted to ensure off-chain processes can properly react to this system adjustment.
Alleviation (f6f1ad0b8f24a96ade345db1dd05a1878eb0f761):
The AdminContractAddressSet
event was introduced to the codebase and is correspondingly emitted in the CommunityIssuance::setAdminContract
function, addressing this exhibit in full.