Omniscia Vector Finance Audit
Locker Static Analysis Findings
Locker Static Analysis Findings
LOC-01S: Non-Standard Struct Name
Type | Severity | Location |
---|---|---|
Code Style | Informational | Locker.sol:L18 |
Description:
The linked struct
is set as userDeposit
which is a non-standard name that does not conform to the CapWords
style.
Example:
contracts/Locker.sol
18struct userDeposit {19 uint256 depositTime;20 uint256 endTime;21 uint256 amount;22}
Recommendation:
We advise the official Solidity style guide to be adhered to by renaming the struct
to UserDeposit
or Deposit
.
Alleviation:
The struct
was properly renamed as advised.
LOC-02S: Redundant Variable
Type | Severity | Location |
---|---|---|
Gas Optimization | Informational | Locker.sol:L25 |
Description:
The linked variable remains unutilized in the codebase.
Example:
contracts/Locker.sol
25mapping(address => uint256) depositNumbers;
Recommendation:
We advise it to be safely omitted.
Alleviation:
The Vector Finance team considered this exhibit but opted not to apply a remediation for it in the current iteration of the codebase.