Omniscia Vector Finance Audit

Manual Review

Manual Review

A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in Vector Finance's staking and reward mechanisms.

As the project at hand implements complex staking and reward mechanisms integrating with Platypus Finance, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification as well as Platypus Finance's integration documentation.

We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed multiple major vulnerabilities within the system which could have had severe ramifications to its overall operation, however, they were conveyed ahead of time to the Vector Finance team to be promptly remediated.

Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to a certain extent, however, we strongly recommend the documentation of the project to be expanded at certain complex points such as the APR calculations.

A total of 36 findings were identified over the course of the manual review of which 20 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.

The finding table below enumerates all these security / behavioural findings:

IDSeverityAddressedTitle
BRP-01MMinorYesImproper Invocation of EIP-20 transferFrom
BRP-02MMajorYesImproper Unit Neutralization
CAP-01MMinorYesInexplicable Condition Effect
CAP-02MMinorYesInexplicable Re-Invocation Capability
ERC-01MMediumYesOverly Centralized Functionality
LOC-01MMinorYesImproper Invocation of EIP-20 transferFrom
LOC-02MMinorYesImproper Usage of Indexes
LOC-03MMinorYesInexistent Sanitization of Max Deposits
LOC-04MMediumYesInexistent Restriction of Token Flow
MSG-01MMinorNoImproper Invocation of EIP-20 transferFrom / transfer
MSG-02MMinorYesInexplicable Re-Invocation Capability
MSG-03MMediumYesImproper Fee Limit Enforcement
MSG-04MMediumNoImproper Slippage Validation
MSG-05MMediumYesInexistent Validation of Existing Entry
MSG-06MMediumYesUnfair System Inflow / Outflow Evaluation
MCV-01MMinorYesIll-Advised Toggle Pattern
MCV-02MMediumYesImproper Maintenance of Pool Info Array
POO-01MMajorYesIncorrect User Incentives
VTX-01MMediumYesOverly Centralized Minting Functionality
PTP-01MMinorYesImproper Invocation of EIP-20 transferFrom