poolHelper Code Style Findings

POO-01C: Inexistent Visibility Specifier

Description:

The linked variable has no visibility specifier explicitly set.

Example:

Copy
22uint256 pid;

Recommendation:

We advise one to be set so to avoid potential compilation discrepancies in the future as the default behaviour is for the compiler to assign one automatically which may change in future pragma versions.

Alleviation:

The public visibility specifier was properly introduced for the linked variable.

POO-02C: Variable Mutability Optimization

Description:

The linked variables are assigned to only once during the contract's constructor.

Example:

Copy
27constructor(
28    uint256 _pid,
29    address _stakingToken,
30    address _depositToken,
31    address _mainStaking,
32    address _masterVtx,
33    address _rewarder
34) {
35    pid = _pid;
36    stakingToken = _stakingToken;
37    depositToken = _depositToken;
38    mainStaking = _mainStaking;
39    masterVtx = _masterVtx;
40    rewarder = _rewarder;
41}

Recommendation:

We advise them to be set as immutable greatly optimizing their gas cost.

Alleviation:

All linked variables were correctly set as immutable.