Omniscia Vector Finance Audit

Code Style

Code Style

During the manual portion of the audit, we identified 16 optimizations that can be applied to the codebase that will decrease the gas-cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.

Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.

These optimizations are enumerated below:

IDSeverityAddressedTitle
BRP-01CInformationalYesInefficient Usage of Reward Tokens
BRP-02CInformationalNoInefficient Variable Utilization
BRP-03CInformationalYesInexistent Error Message
BRP-04CInformationalYesVariable Mutability Optimization
LOC-01CInformationalNoInexistent Error Messages
LOC-02CInformationalYesInexistent Visibility Specifier
LOC-03CInformationalYesVariable Mutability Optimization
MSG-01CInformationalYesRedundant Timestamp Offset
MSG-02CInformationalYesRedundant memory Pointer
MCV-01CInformationalYesInexistent Error Message
OWN-01CInformationalYesRedundant Invocation of Getter Function
OWN-02CInformationalYesRedundant Local Variable Declaration
POO-01CInformationalYesInexistent Visibility Specifier
POO-02CInformationalYesVariable Mutability Optimization
PTP-01CInformationalYesInexistent Error Message
PTP-02CInformationalYesVariable Mutability Optimization