Omniscia Vendor Finance Audit
LendingPoolImplementation Code Style Findings
LendingPoolImplementation Code Style Findings
LPI-01C: Repetitive Value Literal
| Type | Severity | Location |
|---|---|---|
| Code Style |  | LendingPoolImplementation.sol:L156, L312, L317 |
Description:
The linked value literal is repeated across the codebase multiple times.
Example:
contracts/LendingPoolImplementation.sol
156_amount + ((totalFees * protocolFee) / 1000000)Recommendation:
We advise it to be set to a constant variable instead optimizing the legibility of the codebase.
Alleviation:
A contract-level constant has been declared as HUNDRED_PERCENT replacing all instances of the literal and optimizing the legibility of the codebase.