Omniscia Vendor Finance Audit
VendorPoolFactory Code Style Findings
VendorPoolFactory Code Style Findings
VPF-01C: Repetitive Value Literal
| Type | Severity | Location |
|---|---|---|
| Code Style |  | VendorPoolFactory.sol:L148, L186, L187, L202, L203, L322 |
Description:
The linked value literal is repeated across the codebase multiple times.
Example:
contracts/VendorPoolFactory.sol
148if (_feeRate > 1000000) revert FeeTooLarge();Recommendation:
We advise it to be set to a constant variable instead optimizing the legibility of the codebase.
Alleviation:
A contract-level constant has been declared as HUNDRED_PERCENT replacing all instances of the literal and optimizing the legibility of the codebase.