LendingPoolImplementation Static Analysis Findings

LPI-01S: Illegible Numeric Value Representation

Type	Severity	Location
Code Style		LendingPoolImplementation.sol:L156, L312, L317

Description:

The linked representation of a numeric literal is sub-optimally represented decreasing the legibility of the codebase.

Example:

Copy
156_amount + ((totalFees * protocolFee) / 1000000)

Recommendation:

To properly illustrate the value's purpose, we advise the following guidelines to be followed. For values meant to depict fractions with a base of 1e18, we advise fractions to be utilized directly (i.e. 1e17 becomes 0.1e18) as they are supported. For values meant to represent a percentage base, we advise each value to utilize the underscore (_) separator to discern the percentage decimal (i.e. 10000 becomes 100_00, 300 becomes 3_00 and so on). Finally, for large numeric values we simply advise the underscore character to be utilized again to represent them (i.e. 1000000 becomes 1_000_000).

Alleviation:

The special separator character has been introduced as advised, properly illustrating the decimal accuracy of the percentage value.

LPI-02S: Mathematical Tautologies

Type	Severity	Location
Code Style		LendingPoolImplementation.sol:L207, L277

Description:

The linked conditionals are either fully or partially redundant as they validate a tautology such as an unsigned integer (uint) being greater-than-or-equal-to zero, a trait that cannot be broken.

Example:

Copy
207if (userReport.borrowAmount <= 0) revert NoDebt();

Recommendation:

We advise the conditionals to be removed from the codebase for the sake of brevity.

Alleviation:

The mathematical tautologies have been properly removed from the codebase optimizing its legibility as well as execution cost.