Omniscia Sheesha Finance Audit

Manual Review

Manual Review

A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in the token-agnostic vesting implementation by Sheesha Finance.

As the project at hand implements a vesting implementation, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification.

We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed the absence of best security practices within the system which can lead to an inexecutable state as well as an overly powerful centralized function, however, they were conveyed ahead of time to the Sheesha Finance team to be promptly remediated.

Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to the extent it need be.

A total of 20 findings were identified over the course of the manual review of which 17 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.

The finding table below enumerates all these security / behavioural findings:

IDSeverityAddressedTitle
AVG-01MMinorYesInexistent Self-Sufficiency
BVG-01MMinorYesECDSA Signature Malleability
BVG-02MMinorYesImproper Edge Case
BVG-03MMinorYesInconsistent Edge Case Handling
BVG-04MMinorYesInexistent Self-Sufficiency
BVG-05MMinorYesOverly Centralized Control
DRI-01MMinorYesImproper Configuration Sanitization
DFE-01MMinorYesImproper Configuration Sanitization
DFE-02MInformationalNoImproper AdvanceVesting Inheritence
EFI-01MMinorYesImproper Configuration Sanitization
FRA-01MMinorYesImproper Configuration Sanitization
MOZ-01MMinorYesImproper Configuration Sanitization
PFE-01MMinorYesImproper Configuration Sanitization
RMR-01MMinorYesImproper Configuration Sanitization
RFE-01MMinorYesImproper Configuration Sanitization
TBK-01MMinorYesImproper Configuration Sanitization
ZIG-01MMinorYesImproper Configuration Sanitization