Omniscia Sheesha Finance Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in the token-agnostic vesting implementation by Sheesha Finance.
As the project at hand implements a vesting implementation, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed the absence of best security practices within the system which can lead to an inexecutable state as well as an overly powerful centralized function, however, they were conveyed ahead of time to the Sheesha Finance team to be promptly remediated.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to the extent it need be.
A total of 20 findings were identified over the course of the manual review of which 17 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
ID | Severity | Addressed | Title |
---|---|---|---|
AVG-01M | Minor | Yes | Inexistent Self-Sufficiency |
BVG-01M | Minor | Yes | ECDSA Signature Malleability |
BVG-02M | Minor | Yes | Improper Edge Case |
BVG-03M | Minor | Yes | Inconsistent Edge Case Handling |
BVG-04M | Minor | Yes | Inexistent Self-Sufficiency |
BVG-05M | Minor | Yes | Overly Centralized Control |
DRI-01M | Minor | Yes | Improper Configuration Sanitization |
DFE-01M | Minor | Yes | Improper Configuration Sanitization |
DFE-02M | Informational | No | Improper AdvanceVesting Inheritence |
EFI-01M | Minor | Yes | Improper Configuration Sanitization |
FRA-01M | Minor | Yes | Improper Configuration Sanitization |
MOZ-01M | Minor | Yes | Improper Configuration Sanitization |
PFE-01M | Minor | Yes | Improper Configuration Sanitization |
RMR-01M | Minor | Yes | Improper Configuration Sanitization |
RFE-01M | Minor | Yes | Improper Configuration Sanitization |
TBK-01M | Minor | Yes | Improper Configuration Sanitization |
ZIG-01M | Minor | Yes | Improper Configuration Sanitization |