Omniscia Sovryn Audit
Bridge Code Style Findings
Bridge Code Style Findings
BRI-01C: Redundant User-Defined Getter
| Type | Severity | Location |
|---|---|---|
| Gas Optimization | Informational | Bridge.sol:L56, L488-L490 |
Description:
The erc777ConverterAddr is a public variable that also possesses a user-defined getter function getErc777Converter.
Example:
sovryn-token-bridge/bridge/contracts/Bridge.sol
488function getErc777Converter() external view returns(address) {489 return erc777ConverterAddr;490}Recommendation:
We advise either the public specifier to be set to internal or the user-defined getter to be omitted, the former of which we recommend as we assume the system is meant to conform to an upgrade-able interface.
Alleviation:
The development team has acknowledged this exhibit but decided to not apply its remediation in the current version of the codebase.