Omniscia DAFI Protocol Audit

Code Style

Code Style

During the manual portion of the audit, we identified 12 optimizations that can be applied to the codebase that will decrease the gas-cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.

Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.

These optimizations are enumerated below:

IDSeverityAddressedTitle
BTN-01CInformationalNoInaccurate Evaluation
BTN-02CInformationalNoNonstandard Naming Convention
BTN-03CInformationalNoRedundant SafeMath Invocation
BTN-04CInformationalNoVisibility Specifiers Missing
DAF-01CInformationalNoRedundant Usage of Storage
DAT-01CInformationalNoSystem Optimization
DAT-02CInformationalYesVisibility Specifiers Missing
OWN-01CInformationalYesInexistent Error Messages
PFD-01CInformationalNoRedundant Code
DTO-01CInformationalNoCodebase Optimization
DTO-02CInformationalNoRedundant Assignment
DTO-03CInformationalNoRedundant Check