Omniscia DAFI Protocol Audit

ERC20 Static Analysis Findings

ERC20 Static Analysis Findings

ERC-01S: Improper Declaration

TypeSeverityLocation
Code StyleInformationalERC20.sol:L5-L10

Description:

The ERC20 declaration is currently a contract with no assignment or function implemented.

Example:

contracts/ERC20.sol
4contract ERC20 is ERC20Basic {
5 function allowance(address owner, address spender) public view returns (uint256);
6 function transferFrom(address from, address to, uint256 value) public returns (bool);
7 function approve(address spender, uint256 value) public returns (bool);
8 event Approval(address indexed owner, address indexed spender, uint256 value);
9}

Recommendation:

We advise it to be declared as an interface better reflecting what it represents.The development team has acknowledged this exhibit but decided to not apply its remediation in the current version of the codebase citing time constraints.

Alleviation:

The development team has acknowledged this exhibit but decided to not apply its remediation in the current version of the codebase citing time constraints.