DAFIPlatform Static Analysis Findings

DAI-01S: Inexistent Zero-Address Checks

Description:

The constructor of the DAFIPlatform does not evaluate whether its input address arguments are not equal to the zero address which can lead to a misconfiguration of the system, especially in the case of the wallet address.

Example:

Copy
27constructor( IDAFI _DAFIContract, IData _dataContract, address payable _wallet) public Ownable(msg.sender){
28    
29    DAFIContract = _DAFIContract;
30    dataContract = _dataContract;
31    wallet = _wallet;
32}

Recommendation:

We advise the addresses to be properly sanitized via a corresponding require check for each variable.

Alleviation:

A zero address check was properly introduced for the _wallet address of the contract's constructor.