Omniscia DAFI Protocol Audit
ERC20Basic Static Analysis Findings
ERC20Basic Static Analysis Findings
ERB-01S: Improper Declaration
Type | Severity | Location |
---|---|---|
Code Style | Informational | ERC20Basic.sol:L5-L10 |
Description:
The ERC20Basic
declaration is currently a contract
with no assignment or function implemented.
Example:
contracts/ERC20Basic.sol
5contract ERC20Basic {6 function totalSupply() public view returns (uint256);7 function balanceOf(address who) public view returns (uint256);8 function transfer(address to, uint256 value) public returns (bool);9 event Transfer(address indexed from, address indexed to, uint256 value);10}
Recommendation:
We advise it to be declared as an interface
better reflecting what it represents.The development team has acknowledged this exhibit but decided to not apply its remediation in the current version of the codebase citing time constraints.
Alleviation:
The development team has acknowledged this exhibit but decided to not apply its remediation in the current version of the codebase citing time constraints.