Omniscia Hot Cross Audit

CrossMint1155Factory Code Style Findings

CrossMint1155Factory Code Style Findings

CON-01C: Data Location Optimization

TypeSeverityLocation
Gas OptimizationInformationalCrossMint1155Factory.sol:L11-L13

Description:

The deployCrossMint1155 function accepts memory arguments and is declared as external.

Example:

contracts/libs/CrossMint1155Factory.sol
9function deployCrossMint1155(
10 bytes32 salt,
11 string memory name,
12 string memory symbol,
13 string memory baseURI,
14 address owner
15) external returns (address) {

Recommendation:

We advise its arguments to be set as calldata greatly optimizing its gas cost.

Alleviation:

The linked arguments were properly set to calldata.