Omniscia Hot Cross Audit
CrossMint721Factory Code Style Findings
CrossMint721Factory Code Style Findings
CMF-01C: Data Location Optimization
Type | Severity | Location |
---|---|---|
Gas Optimization | Informational | CrossMint721Factory.sol:L11-L13 |
Description:
The deployCrossMint721
function accepts memory
arguments and is declared as external
.
Example:
contracts/libs/CrossMint721Factory.sol
9function deployCrossMint721(10 bytes32 salt,11 string memory name,12 string memory symbol,13 string memory baseURI,14 address owner15) external returns (address) {
Recommendation:
We advise its arguments to be set as calldata
greatly optimizing its gas cost.
Alleviation:
The linked arguments were properly set to calldata
.