Omniscia Hot Cross Audit
MinterControl Code Style Findings
MinterControl Code Style Findings
MCL-01C: Redundant Visibility Specifier
| Type | Severity | Location |
|---|---|---|
| Gas Optimization | Informational | MinterControl.sol:L7 |
Description:
The MINTER_ROLE variable is a contract-level constant declared as public.
Example:
contracts/utils/MinterControl.sol
7bytes32 public constant MINTER_ROLE = keccak256("MINTER_ROLE");Recommendation:
We advise the visibility specifier to be adjusted to either private or internal to optimize the contract's bytecode.
Alleviation:
The visibility specifier of the variable was set to private and a new, similar variable labelled ADMIN_ROLE was also declared with a private specifier properly.