Omniscia Hot Cross Audit

Manual Review

Manual Review

A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in the NFT contract factory and minter implementation of Hot Cross.

As the project at hand implements multiple NFT standards, intricate care was put into ensuring that the flow of assets within the system conforms to the specifications and restrictions laid forth within the protocol's specification.

We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed a logical fallacy within the system with regards to permission delegation which allow a creator of an NFT contract to bypass all fees, however, this was conveyed ahead of time to the Hot Cross team to be promptly remediated.

Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to an exemplary extent.

A total of 11 findings were identified over the course of the manual review of which 4 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.

The finding table below enumerates all these security / behavioural findings:

IDSeverityAddressedTitle
CMT-01MMajorYesPre-Condition Bypass
CMT-02MMediumYesUser Based Salt
CM5-01MInformationalYesRedundant Declaration
MCO-01MMinorYesImproper Visibility Specifier